Don't add dhcp rules for multiasic testbed#6165
Closed
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
Closed
Don't add dhcp rules for multiasic testbed#6165ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Zhaohui Sun <[email protected]>
Contributor
Author
|
The issue was fixed in this PR #6170. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhaohui Sun [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_multiasic_cacl_applicationfailed at adding dhcp rules ingenerate_expected_rules.How did you do it?
Add a check, if it's multiasic, will not call
iptables_rules.extend(expected_dhcp_rules_for_standby).How did you verify/test it?
run c
acl/test_cacl_application.py::test_multiasic_cacl_applicationAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation